Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Remove unused chart theme code #657

Conversation

SergeyMyssak
Copy link
Collaborator

Description

Removed unused chart theme code and imports

Issues Resolved

#656

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Co-authored-by: Andrey Myssak <andreymyssak@gmail.com>
Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
@SergeyMyssak SergeyMyssak requested a review from a team as a code owner April 2, 2023 14:40
Copy link
Contributor

@BSFishy BSFishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good

@ashwin-pc ashwin-pc added the CCI College Contributor Initiative label Apr 7, 2023
@joshuarrrr joshuarrrr merged commit e9a63af into opensearch-project:main Apr 12, 2023
5 checks passed
AMoo-Miki added a commit to AMoo-Miki/oui that referenced this pull request Jun 13, 2023
AMoo-Miki added a commit to AMoo-Miki/oui that referenced this pull request Jun 19, 2023
@AMoo-Miki AMoo-Miki mentioned this pull request Jun 19, 2023
6 tasks
andreymyssak added a commit to andreymyssak/oui that referenced this pull request Jun 20, 2023
andreymyssak added a commit to andreymyssak/oui that referenced this pull request Jun 20, 2023
This reverts commit e9a63af.

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
AMoo-Miki added a commit to AMoo-Miki/oui that referenced this pull request Jun 21, 2023
andreymyssak added a commit to andreymyssak/oui that referenced this pull request Jun 23, 2023
This reverts commit e9a63af.

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
AMoo-Miki added a commit to AMoo-Miki/oui that referenced this pull request Jun 29, 2023
AMoo-Miki added a commit to AMoo-Miki/oui that referenced this pull request Jun 29, 2023
joshuarrrr added a commit that referenced this pull request Jul 5, 2023
* Revert "Remove unused chart theme code (#657)"

This reverts commit e9a63af.

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>

* Revert "Remove charts theme code (#554)"

This reverts commit 2086980.

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>

---------

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCI College Contributor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants