Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update netty and gson versions #274

Conversation

kiranprakash154
Copy link
Contributor

@kiranprakash154 kiranprakash154 commented Sep 15, 2022

Signed-off-by: Kiran Prakash awskiran@amazon.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Updating the versions of the below libraries because of the cyclic dependency PA-RCA brings from this PR

Describe the solution you are proposing
Updating gson version from 2.8.9 to 2.9.0
Including io.netty:netty-transport-native-unix-common coz of the dependency PA RCA is bringing in.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kiran Prakash <awskiran@amazon.com>
@kiranprakash154 kiranprakash154 changed the title update netty and gson Update netty and gson versions Sep 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #274 (cd0bb2d) into main (b4eb12b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #274   +/-   ##
=========================================
  Coverage     71.84%   71.84%           
  Complexity      368      368           
=========================================
  Files            44       44           
  Lines          2522     2522           
  Branches        171      171           
=========================================
  Hits           1812     1812           
  Misses          598      598           
  Partials        112      112           
Impacted Files Coverage Δ
...performanceanalyzer/PerformanceAnalyzerPlugin.java 76.92% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kiranprakash154 kiranprakash154 marked this pull request as ready for review September 15, 2022 21:49
@kiranprakash154 kiranprakash154 requested a review from a team September 15, 2022 21:49
@kiranprakash154 kiranprakash154 merged commit bdb4e7f into opensearch-project:main Sep 15, 2022
@kiranprakash154 kiranprakash154 deleted the kp/update-netty-gson-1 branch September 15, 2022 22:13
@kiranprakash154 kiranprakash154 self-assigned this Sep 15, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-274-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bdb4e7f5fca0bc49d5ee2c5c21809a302e385cdd
# Push it to GitHub
git push --set-upstream origin backport/backport-274-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-274-to-1.x.

kiranprakash154 added a commit to kiranprakash154/performance-analyzer that referenced this pull request Sep 15, 2022
Signed-off-by: Kiran Prakash <awskiran@amazon.com>

Signed-off-by: Kiran Prakash <awskiran@amazon.com>
(cherry picked from commit bdb4e7f)
kiranprakash154 added a commit to kiranprakash154/performance-analyzer that referenced this pull request Sep 16, 2022
Signed-off-by: Kiran Prakash <awskiran@amazon.com>

Signed-off-by: Kiran Prakash <awskiran@amazon.com>
(cherry picked from commit bdb4e7f)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-274-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bdb4e7f5fca0bc49d5ee2c5c21809a302e385cdd
# Push it to GitHub
git push --set-upstream origin backport/backport-274-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-274-to-1.3.

kiranprakash154 added a commit to kiranprakash154/performance-analyzer that referenced this pull request Sep 16, 2022
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
(cherry picked from commit bdb4e7f)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-274-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bdb4e7f5fca0bc49d5ee2c5c21809a302e385cdd
# Push it to GitHub
git push --set-upstream origin backport/backport-274-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-274-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-274-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bdb4e7f5fca0bc49d5ee2c5c21809a302e385cdd
# Push it to GitHub
git push --set-upstream origin backport/backport-274-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3

Then, create a pull request where the base branch is 2.3 and the compare/head branch is backport/backport-274-to-2.3.

kiranprakash154 added a commit to kiranprakash154/performance-analyzer that referenced this pull request Sep 16, 2022
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
(cherry picked from commit bdb4e7f)
kiranprakash154 added a commit that referenced this pull request Sep 19, 2022
* update netty and gson (#274)

Signed-off-by: Kiran Prakash <awskiran@amazon.com>
(cherry picked from commit bdb4e7f)
kiranprakash154 added a commit that referenced this pull request Sep 19, 2022
* update netty and gson (#274)
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
(cherry picked from commit bdb4e7f)

* push the jar

Signed-off-by: Kiran Prakash <awskiran@amazon.com>

Signed-off-by: Kiran Prakash <awskiran@amazon.com>
kiranprakash154 added a commit that referenced this pull request Sep 19, 2022
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
(cherry picked from commit bdb4e7f)
kaushalmahi12 pushed a commit to kaushalmahi12/performance-analyzer that referenced this pull request Oct 25, 2022
Signed-off-by: Kiran Prakash <awskiran@amazon.com>

Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants