Avoid appending origin to branch name twice for checking out PA RCA #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
kiranprakash154
changed the title
Codecov Report
@@ Coverage Diff @@
## main #284 +/- ##
============================================
- Coverage 71.84% 71.68% -0.16%
+ Complexity 368 367 -1
============================================
Files 44 44
Lines 2522 2522
Branches 171 171
============================================
- Hits 1812 1808 -4
- Misses 598 601 +3
- Partials 112 113 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5 tasks
sruti1312
previously approved these changes
Sep 26, 2022
sgup432
reviewed
Sep 26, 2022
dzane17
previously approved these changes
Sep 26, 2022
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
kiranprakash154
dismissed stale reviews from dzane17 and sruti1312
via
c5138fe
sruti1312
approved these changes
Sep 26, 2022
dzane17
approved these changes
Sep 26, 2022
kaushalmahi12
pushed a commit
to kaushalmahi12/performance-analyzer
that referenced
this pull request
Oct 25, 2022
…pensearch-project#284) * safeguard against appending origin twice Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kiran Prakash awskiran@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
The Builds are failing with this error
This adds safeguards against build triggers with a branch or without a branch.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.