Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade netty to 4.1.86 #352

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Upgrade netty to 4.1.86 #352

merged 1 commit into from
Dec 29, 2022

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Dec 29, 2022

Signed-off-by: David Zane davizane@amazon.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Fixes #348

Describe the solution you are proposing
Use netty version defined in OS core. Guava is already on v30.1

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: David Zane <davizane@amazon.com>
@dzane17 dzane17 requested a review from a team December 29, 2022 18:52
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #352 (a231b5c) into main (b8d3a4c) will increase coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #352      +/-   ##
============================================
+ Coverage     70.67%   70.90%   +0.23%     
- Complexity      371      373       +2     
============================================
  Files            44       44              
  Lines          2581     2581              
  Branches        174      174              
============================================
+ Hits           1824     1830       +6     
+ Misses          644      639       -5     
+ Partials        113      112       -1     
Impacted Files Coverage Δ
.../collectors/ClusterManagerServiceEventMetrics.java 73.68% <0.00%> (+1.31%) ⬆️
...ormanceanalyzer/writer/EventLogQueueProcessor.java 60.71% <0.00%> (+4.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dzane17 dzane17 merged commit d462e20 into main Dec 29, 2022
@dzane17 dzane17 deleted the feature/netty branch December 29, 2022 21:33
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 30, 2022
Signed-off-by: David Zane <davizane@amazon.com>

Signed-off-by: David Zane <davizane@amazon.com>
(cherry picked from commit d462e20)
@dzane17
Copy link
Contributor Author

dzane17 commented Dec 30, 2022

Netty not used in 1.x

dzane17 pushed a commit that referenced this pull request Jan 3, 2023
Signed-off-by: David Zane <davizane@amazon.com>
(cherry picked from commit d462e20)
dzane17 added a commit that referenced this pull request Jan 5, 2023
Signed-off-by: David Zane <davizane@amazon.com>

Signed-off-by: David Zane <davizane@amazon.com>
kaushalmahi12 pushed a commit to kaushalmahi12/performance-analyzer that referenced this pull request Jan 18, 2023
Signed-off-by: David Zane <davizane@amazon.com>

Signed-off-by: David Zane <davizane@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Netty & Guava dependencies - autoclosed
4 participants