Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish snapshot to maven #400

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Mar 17, 2023

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#385

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Testing

./gradlew publishPluginZipPublicationToSnapshotsRepository
find snapshots | sort
snapshots
snapshots/org
snapshots/org/opensearch
snapshots/org/opensearch/plugin
snapshots/org/opensearch/plugin/performance-analyzer
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/maven-metadata.xml
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/maven-metadata.xml.md5
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha1
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha256
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha512
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20230317.090441-1.pom
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20230317.090441-1.pom.md5
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20230317.090441-1.pom.sha1
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20230317.090441-1.pom.sha256
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20230317.090441-1.pom.sha512
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20230317.090441-1.zip
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20230317.090441-1.zip.md5
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20230317.090441-1.zip.sha1
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20230317.090441-1.zip.sha256
snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20230317.090441-1.zip.sha512
snapshots/org/opensearch/plugin/performance-analyzer/maven-metadata.xml
snapshots/org/opensearch/plugin/performance-analyzer/maven-metadata.xml.md5
snapshots/org/opensearch/plugin/performance-analyzer/maven-metadata.xml.sha1
snapshots/org/opensearch/plugin/performance-analyzer/maven-metadata.xml.sha256
snapshots/org/opensearch/plugin/performance-analyzer/maven-metadata.xml.sha512

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
push:
branches:
- 'main'
- '1.*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.x do not have this task. It started from 2.x. Would recommend to remove this to avoid failures.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this

gaiksaya
gaiksaya previously approved these changes Mar 17, 2023
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Role has been added to the secrets.

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
@sgup432 sgup432 merged commit 13eda9f into opensearch-project:main Mar 17, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 17, 2023
* Publish snapshot to maven

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

* Removing 1.x branch from maven publish workflow

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

---------

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
(cherry picked from commit 13eda9f)
sgup432 added a commit that referenced this pull request Mar 17, 2023
* Publish snapshot to maven

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

* Removing 1.x branch from maven publish workflow

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

---------

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
(cherry picked from commit 13eda9f)

Co-authored-by: Sagar <99425694+sgup432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants