Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collector update Stat calls #420

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

Tjofil
Copy link
Contributor

@Tjofil Tjofil commented Apr 11, 2023

Signed-off-by: Filip Drobnjakovic drobnjakovicfilip@gmail.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
PR to adjust to changes in opensearch-project/performance-analyzer-rca#323.

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #420 (60a775b) into main (2a1861b) will decrease coverage by 0.25%.
The diff coverage is 76.92%.

❗ Current head 60a775b differs from pull request most recent head 7487d70. Consider uploading reports for the commit 7487d70 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #420      +/-   ##
============================================
- Coverage     72.20%   71.95%   -0.25%     
+ Complexity      375      374       -1     
============================================
  Files            44       44              
  Lines          2547     2560      +13     
  Branches        173      173              
============================================
+ Hits           1839     1842       +3     
- Misses          600      609       +9     
- Partials        108      109       +1     
Impacted Files Coverage Δ
...ceanalyzer/collectors/CircuitBreakerCollector.java 82.22% <75.00%> (-11.90%) ⬇️
...lyzer/collectors/ClusterManagerServiceMetrics.java 62.50% <100.00%> (+1.63%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@khushbr khushbr self-requested a review April 17, 2023 18:23
@khushbr khushbr merged commit b579583 into opensearch-project:main Apr 17, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2023
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit b579583)
khushbr pushed a commit that referenced this pull request Apr 18, 2023
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
(cherry picked from commit b579583)

Co-authored-by: Filip Drobnjaković <drobnjakovicfilip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants