WriterMetrics and config files dependency redirection #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com>
Tjofil
requested review from
praveensameneni,
khushbr,
ansjcy,
goyamegh,
getsaurabh02,
sbcd90 and
sgup432
as code owners
Codecov Report
@@ Coverage Diff @@
## main #450 +/- ##
============================================
+ Coverage 72.13% 72.20% +0.06%
Complexity 375 375
============================================
Files 44 44
Lines 2591 2590 -1
Branches 173 173
============================================
+ Hits 1869 1870 +1
+ Misses 614 612 -2
Partials 108 108
|
khushbr
reviewed
May 24, 2023
| @@ -299,7 +299,7 @@ dependencies { | |||
| implementation 'org.bouncycastle:bcprov-jdk15on:1.70' | |||
| implementation 'org.bouncycastle:bcpkix-jdk15on:1.70' | |||
| implementation "org.opensearch:performanceanalyzer-rca:${version}" | |||
| implementation "org.opensearch:performanceanalyzer-commons:${version}" | |||
| implementation "org.opensearch:performance-analyzer-commons:1.0.0-SNAPSHOT" | |||
There was a problem hiding this comment.
1.0.0-SNAPSHOT is meant for tracking active development and we use the release version otherwise.
Let us fix this in follow-up PR.
khushbr
approved these changes
May 24, 2023
ansjcy
approved these changes
May 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 31, 2023
* Config files dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * WriterMetrics dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Commons dependency, license and notice. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> --------- Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> (cherry picked from commit bd5bc40)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 31, 2023
* Config files dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * WriterMetrics dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Commons dependency, license and notice. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> --------- Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> (cherry picked from commit bd5bc40)
khushbr
pushed a commit
that referenced
this pull request
May 31, 2023
* Config files dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * WriterMetrics dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Commons dependency, license and notice. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> --------- Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> (cherry picked from commit bd5bc40) Co-authored-by: Filip Drobnjaković <drobnjakovicfilip@gmail.com>
khushbr
pushed a commit
that referenced
this pull request
May 31, 2023
* Config files dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * WriterMetrics dependency redirection. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> * Commons dependency, license and notice. Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> --------- Signed-off-by: Filip Drobnjakovic <drobnjakovicfilip@gmail.com> (cherry picked from commit bd5bc40) Co-authored-by: Filip Drobnjaković <drobnjakovicfilip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirected
WriterMetricsand config file dependencies from PA-RCA repo to Commons.Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.