Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new maintainers to repo #600

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Add new maintainers to repo #600

merged 1 commit into from
Nov 22, 2023

Conversation

khushbr
Copy link
Collaborator

@khushbr khushbr commented Nov 22, 2023

  1. Add new Contributors to the repo
  2. Bump Commons library version

Check List

  • Backport Labels added.
  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e2b749) 69.13% compared to head (2377260) 69.13%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #600   +/-   ##
=========================================
  Coverage     69.13%   69.13%           
  Complexity      370      370           
=========================================
  Files            44       44           
  Lines          2689     2689           
  Branches        172      172           
=========================================
  Hits           1859     1859           
  Misses          726      726           
  Partials        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansjcy ansjcy merged commit 43367b1 into opensearch-project:main Nov 22, 2023
9 of 11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-600-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 43367b1d3af866cd40d2233098c1ac187932a6b5
# Push it to GitHub
git push --set-upstream origin backport/backport-600-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-600-to-1.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 43367b1)
khushbr added a commit that referenced this pull request Nov 23, 2023
Signed-off-by: Khushboo Rajput <khushbr@amazon.com>
(cherry picked from commit 43367b1)

Co-authored-by: Khushboo Rajput <59671881+khushbr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants