Fixed the bug in CacheConfigMetricsCollector #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
atharvasharma61
requested review from
khushbr,
ansjcy,
sbcd90,
Shephalimittal,
nishchay21,
rramachand21,
psychbot and
Gaganjuneja
as code owners
|
Test failures will be addressed in the following PR: #651 |
psychbot
reviewed
Jun 4, 2024
| @@ -118,10 +122,15 @@ public void collectMetrics(long startTime) { | |||
| SHARD_REQUEST_CACHE.toString(), | |||
| requestCacheMaxSize); | |||
| } catch (Exception e) { | |||
| return new CacheMaxSizeStatus( | |||
There was a problem hiding this comment.
Can you provide more insight as to why do we need to modify this?
There was a problem hiding this comment.
The current logic returns a CacheMaxSizeStatus with null cacheMaxSize if exception is raised, while we require it to be non-null.
|
@atharvasharma61 thanks for raising this. Could you please add the following details here?
|
Hi Gagan. Thanks for responding.
|
How come it got released then? |
Looks like it is a miss. UT has been failing for quite some time. PR from 3 months ago: https://github.com/opensearch-project/performance-analyzer/actions/runs/8379459182/job/22946424856 |
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gaganjuneja
approved these changes
Jun 11, 2024
nishchay21
approved these changes
Jun 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Fixed the bug in CacheConfigMetricsCollector Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Fixes error logging Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> (cherry picked from commit 489f318)
Gaganjuneja
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Fixed the bug in CacheConfigMetricsCollector Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Fixes error logging Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> (cherry picked from commit 489f318) Co-authored-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Resolves #644
Metrics are being emitted as expected:
Describe the solution you are proposing
Tiered Caching has introduced a new ICache interface which has an OnHeap implementation which actually stores the Cache field now. We had to update the logic to how to get the cache field. Relevant PR: opensearch-project/OpenSearch#10753
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.