Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating releases page to reflect release windows #1866

Merged
merged 9 commits into from
Aug 17, 2023

Conversation

CEHENKLE
Copy link
Member

Description

updated release page to reflect opensearch-project/.github#150

Issues Resolved

opensearch-project/.github#150

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

…cribing the process

Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
@CEHENKLE
Copy link
Member Author

@bbarani useful?

Signed-off-by: CEHENKLE <henkle@amazon.com>
releases.md Outdated

**Note:** If we cannot pass the exit criteria by 2 weeks after the start of the release cycle window, we will cancel the minor release and hold changes until the next release window.
**Note:** If we cannot pass the exit criteria by 2 weeks after the start of the release cycle window (1 week for 1.x releases), we will cancel the minor release and hold changes until the next release window.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only do patch release in 1.x line. I assume the updated release process is only valid for minor and patch release will still follow release train model?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I updated it to being "1 week for 1.x patch releases", would that be more or less clear?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Patch release still follows release train model so just want to make sure that no one gets confused with updated minor release process.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, updated. Please review, LMK if there are any other changes. Thanks!

Copy link
Member

@krisfreedain krisfreedain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on too many deletions. There's a comment from @bbarani in there as well

| 1.3.11 | June 22nd | June 29th |
| 2.9.0 | July 11th | July 24th |
| 1.3.12 | August 3rd | August 10th |
| 2.10.0 | September 05th | TBD |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to delete this history as we move it to a 'Release History' section at the end of the year.

Copy link
Member Author

@CEHENKLE CEHENKLE Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I reread your comment, and realized you were right. Sorry! Updated.

Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
Signed-off-by: CEHENKLE <henkle@amazon.com>
bbarani
bbarani previously approved these changes Aug 16, 2023
@krisfreedain
Copy link
Member

hold - resolving issues with the table layout

moved the "<div class="table-styler"></div>" down so the first table displays correctly

dropped the '2023' from the first table, it seems unnecessary with this new layout

Signed-off-by: Kris Freedain <kris@freedain.com>
@krisfreedain
Copy link
Member

Minor edits made - LGTM

Copy link
Member

@krisfreedain krisfreedain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisfreedain krisfreedain merged commit cf59fd2 into opensearch-project:main Aug 17, 2023
3 checks passed
captn3m0 added a commit to endoflife-date/endoflife.date that referenced this pull request Aug 18, 2023
As per opensearch-project/project-website#1866

There's a few other wording changes, but they're minor so we can ignore them
marcwrobel added a commit to endoflife-date/endoflife.date that referenced this pull request Aug 18, 2023
As per opensearch-project/project-website#1866. There's a few other wording changes, but they're minor so we can ignore them.

Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com>
Co-authored-by: BiNZGi <BiNZGi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants