Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default notification text message to html #141

Closed

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li joshuali925@gmail.com

Description

The htmlDescription is set when user manually enters a notifications message, but it is empty with the default New report available to view and email notifications doesn't have a body.

This PR sets the default htmlDescription according to textDescription.

FYI @zhongnansu:
https://github.com/opensearch-project/notifications/blob/9a0458f590f1cb8fa98cbdefebf3ed3303669de5/notifications/spi/src/main/kotlin/org/opensearch/notifications/spi/client/EmailMimeProvider.kt#L77-L80
Although you added textPart in MimeMessage, textDescription in email channel doesn't work, only htmlDescription does. Is this expected?

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2021

Codecov Report

Merging #141 (8516c7f) into main (a238baf) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #141      +/-   ##
============================================
- Coverage     63.22%   63.21%   -0.02%     
  Complexity      297      297              
============================================
  Files            97       97              
  Lines          4128     4129       +1     
  Branches        639      639              
============================================
  Hits           2610     2610              
- Misses         1377     1378       +1     
  Partials        141      141              
Flag Coverage Δ
dashboards-reports 73.26% <0.00%> (-0.04%) ⬇️
reports-scheduler 53.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/report_definitions/delivery/delivery.tsx 30.90% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a238baf...8516c7f. Read the comment docs.

@zhongnansu
Copy link
Member

I just saw your message in the PR description. Sending only text message sould work for email. I'll look into this.

@joshuali925
Copy link
Member Author

closing for #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants