Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add auto-backport functionality for reporting #286

Merged
merged 4 commits into from
Feb 24, 2022
Merged

add auto-backport functionality for reporting #286

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3063db7
add auto-backport functionality for reporting
davidcui1225 Feb 23, 2022
cff0144
fixed line break formatting and added rest of the backport documentation
davidcui1225 Feb 23, 2022
f1306c3
update backport workflow and add auto-delete
davidcui1225 Feb 23, 2022
da56ed9
fix link to backport workflow
davidcui1225 Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/backport.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Backport
on:
pull_request:
types:
- closed
- labeled

jobs:
backport:
runs-on: ubuntu-latest
name: Backport
steps:
- name: Backport
uses: tibdex/backport@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
6 changes: 6 additions & 0 deletions dashboards-reports/DEVELOPER_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,9 @@ Example output: `./build/reports-dashboards-0.0.1.zip`
- `yarn test:jest`

Runs the plugin tests.

### Backports

The Github workflow in [`backport.yml`](../.github/workflows/backport.yml) creates backport PRs automatically when the
original PR with an appropriate label `backport <backport-branch-name>` is merged to main with the backport workflow
run successfully on the PR. For example, if a PR on main needs to be backported to `1.x` branch, add a label
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we use line-breaks to format in markdown files? And should this be

Suggested change
run successfully on the PR. For example, if a PR on main needs to be backported to `1.x` branch, add a label
run successfully on the PR. For example, if a PR on main needs to be backported to `1.x` branch, add a label `backport 1.x`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good catch, I missed the whole message in my paste. Also any idea why the link checker might be failing? I can access all of the URLs in my browser as they are listed in the failed action's raw logs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm not sure, might be network issue, retry it later?