Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][2.x]Add ignoreFailure and pipelineContext (#152) #158

Merged

Conversation

mingshl
Copy link
Collaborator

@mingshl mingshl commented Jul 12, 2023

Backport #152

  • Add ignoreFailure and pipelineContext

Signed-off-by: Mingshi Liu mingshl@amazon.com


Signed-off-by: Mingshi Liu mingshl@amazon.com
(cherry picked from commit c15274e)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mingshl mingshl self-assigned this Jul 12, 2023
@mingshl mingshl requested a review from sejli July 12, 2023 00:37
@mingshl mingshl force-pushed the backport/backport-152-to-2.x branch from 80cdc59 to e31367d Compare July 12, 2023 00:38
@mingshl mingshl marked this pull request as ready for review July 12, 2023 00:40
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #158 (d49b2c1) into 2.x (147e19c) will increase coverage by 0.71%.
The diff coverage is 92.30%.

@@             Coverage Diff              @@
##                2.x     #158      +/-   ##
============================================
+ Coverage     82.62%   83.33%   +0.71%     
- Complexity      311      321      +10     
============================================
  Files            41       41              
  Lines          1197     1236      +39     
  Branches        147      152       +5     
============================================
+ Hits            989     1030      +41     
+ Misses          131      130       -1     
+ Partials         77       76       -1     
Impacted Files Coverage Δ
...search/search/relevance/SearchRelevancePlugin.java 0.00% <ø> (ø)
...ch/relevance/configuration/ConfigurationUtils.java 66.66% <62.50%> (ø)
...ng/reranker/impl/AmazonPersonalizedRankerImpl.java 93.25% <97.50%> (+9.25%) ⬆️
...nking/pipeline/KendraRankingResponseProcessor.java 89.79% <100.00%> (ø)
...ntranking/PersonalizeRankingResponseProcessor.java 100.00% <100.00%> (ø)

* Add ignoreFailure and pipelineContext

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* use lowercase

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

---------

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
(cherry picked from commit c15274e)
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@mingshl mingshl force-pushed the backport/backport-152-to-2.x branch from e31367d to d49b2c1 Compare July 12, 2023 01:26
@mingshl mingshl merged commit 76cb2be into opensearch-project:2.x Jul 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant