[BUG] Remove jackson-core dependency #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Li <lnse@amazon.com>
sejli
requested review from
msfroh,
macohen,
noCharger and
mingshl
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
=========================================
Coverage 83.30% 83.30%
Complexity 337 337
=========================================
Files 43 43
Lines 1270 1270
Branches 155 155
=========================================
Hits 1058 1058
Misses 134 134
Partials 78 78 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sean Li <lnse@amazon.com>
reta
reviewed
Nov 29, 2023
reta
reviewed
Nov 29, 2023
Signed-off-by: Sean Li <lnse@amazon.com>
reta
approved these changes
Dec 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
* removing jackson core dependency Signed-off-by: Sean Li <lnse@amazon.com> * readding jackson core and bumping version Signed-off-by: Sean Li <lnse@amazon.com> * bumping versions for jackson databind and annotations Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> (cherry picked from commit f7570dd)
sejli
added a commit
that referenced
this pull request
Dec 6, 2023
* removing jackson core dependency Signed-off-by: Sean Li <lnse@amazon.com> * readding jackson core and bumping version Signed-off-by: Sean Li <lnse@amazon.com> * bumping versions for jackson databind and annotations Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> (cherry picked from commit f7570dd) Co-authored-by: Sean Li <lnse@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that we had a nightly build failure with conflicting
jackson-coredependencies. Sincejackson-corewas bumped to2.16.0in core, our dependency in both processors'build.gradle's are conflicting.This PR reintroduces the question, should we remove thejackson-coredependency in the plugin'sbuild.gradle, or keep bumping the version when it's bumped in core?As discussed in the OpenSearch Search Relevance public meeting, bumping the version to match core seems to be a safer option since previously, there have been issues with removing the dependencies altogether.
Issues Resolved
#133
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.