Commits on Dec 17, 2022

1. Bug fixes and refactoring …

   1. Shallow clone SearchResponse in SearchActionFilter. The only
      properties that we're currently changing are SearchHit and
      timeTookMillis. This is also less brittle as we don't try to
      implement deserialization ourselves.
   2. KendraIntelligentRanker doesn't transform if the required client
      settings (endpoint + execution plan ID) are missing.
   3. A lot of refactoring to prepare for other transformers. Where we
      previously had logic of the form `if kendra_intelligent_ranking then
      do Kendra intelligent ranking`, now the APIs support arbitrary named
      transformers. This required updates to tests and configuration code.
   4. Added tests and fixes for SearchConfigurationExtBuilder.
   
   Signed-off-by: Michael Froh <froh@amazon.com>

   

   msfroh committed Dec 17, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for ddb2bfd
   • Browse repository at this point

   Copy the full SHA

   ddb2bfd View commit details

   Browse the repository at this point in the history

2. Address PR comments from myself …

   Looking at the PR on GitHub, I spotted a few mistakes and possible
   improvements.
   
   Signed-off-by: Michael Froh <froh@amazon.com>

   

   msfroh committed Dec 17, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 258cde4
   • Browse repository at this point

   Copy the full SHA

   258cde4 View commit details

   Browse the repository at this point in the history

3. Address comments by noCharger …

   Signed-off-by: Michael Froh <froh@amazon.com>

   

   msfroh committed Dec 17, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 698f275
   • Browse repository at this point

   Copy the full SHA

   698f275 View commit details

   Browse the repository at this point in the history