Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Detector details has some bad text handling #496

Closed
jovancacvetkovic opened this issue Apr 3, 2023 · 0 comments · Fixed by #505
Closed

[BUG] Detector details has some bad text handling #496

jovancacvetkovic opened this issue Apr 3, 2023 · 0 comments · Fixed by #505
Labels
bug Something isn't working

Comments

@jovancacvetkovic
Copy link
Contributor

What is the bug?

  • The time text for the schedule uses only plurals.
  • Detector dashboard text doesn't wrap and overflows the component boundaries.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Create a detector
  2. Go to detector details
  3. Observe the texts for schedule and dashboard components.

What is the expected behavior?
Text components should not go beyond their boundaries. Text marking the time should use singular nouns for numbers with cipher 1

Do you have any screenshots?
Screenshot from 2023-04-03 17-41-15

@jovancacvetkovic jovancacvetkovic added bug Something isn't working untriaged labels Apr 3, 2023
@lezzago lezzago removed the untriaged label Apr 6, 2023
jovancacvetkovic added a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Apr 7, 2023


Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
jovancacvetkovic added a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Apr 7, 2023


Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
jovancacvetkovic added a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Apr 7, 2023


Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
@jovancacvetkovic jovancacvetkovic mentioned this issue Apr 7, 2023
1 task
AWSHurneyt pushed a commit that referenced this issue Apr 11, 2023
* [BUG] Edit details Save button should be blue #499

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 11, 2023
* [BUG] Edit details Save button should be blue #499

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
(cherry picked from commit dd964d2)
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Apr 18, 2023
* [BUG] Edit details Save button should be blue opensearch-project#499

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit that referenced this issue Apr 18, 2023
* Minor bug fixes (#505)

* [BUG] Edit details Save button should be blue #499

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* [BUG] Fixes few minor UX bugs (#525)

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (#515)

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 18, 2023
* Minor bug fixes (#505)

* [BUG] Edit details Save button should be blue #499

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* [BUG] Fixes few minor UX bugs (#525)

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (#515)

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
(cherry picked from commit d0b1702)
AWSHurneyt added a commit that referenced this issue Apr 18, 2023
* Minor bug fixes (#505)

* [BUG] Edit details Save button should be blue #499

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling #496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* [BUG] Fixes few minor UX bugs (#525)

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (#515)

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) #509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
(cherry picked from commit d0b1702)

Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
* Minor bug fixes (opensearch-project#505)

* [BUG] Edit details Save button should be blue opensearch-project#499

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Detector details has some bad text handling opensearch-project#496

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* [BUG] Fixes few minor UX bugs (opensearch-project#525)

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] deleting detectors should delete all related dashboards (including index patterns and visualisations) (opensearch-project#515)

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Deleting detectors should delete all related dashboards (including index-patterns and visualisations) opensearch-project#509

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Resolved merge conflicts, generated updated snapshot files, resolved discrepancies between main and 2.x branch.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants