Fixed rule object to yaml conversion for timeframe #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
AWSHurneyt
approved these changes
May 10, 2024
amsiglan
added
backport 2.x
backport 2.13
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 2b1c6f1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 2b1c6f1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 2b1c6f1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jun 11, 2024
amsiglan
pushed a commit
that referenced
this pull request
Jun 11, 2024
(cherry picked from commit 2b1c6f1) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the values specified for
Selectionin the visual editor are parsed to lists by default, as a result the timeframe also gets converted to a list in the yaml payload which is incorrect. This PR adds a check for timeframe and parses it as string as expected.After this change we get:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.