[Threat intel][part 3] Support for source type URL_Download and logic to activate/deactivate source #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or sources Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
AWSHurneyt
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
All of the cypress tests passed; the workflow failed during the cleanup step
https://github.com/opensearch-project/security-analytics-dashboards-plugin/actions/runs/9813347173/job/27100043226?pr=1068#step:38:1
Approving
riysaxen-amzn
approved these changes
Jul 5, 2024
eirsep
approved these changes
Jul 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
… to activate/deactivate source (#1068) * added url_download type of threat intel source; activate/deactivate for sources Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added check for controls Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 6b63eb2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
… to activate/deactivate source (#1068) * added url_download type of threat intel source; activate/deactivate for sources Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added check for controls Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 6b63eb2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jul 6, 2024
… to activate/deactivate source (#1068) (#1074) * added url_download type of threat intel source; activate/deactivate for sources * added check for controls --------- (cherry picked from commit 6b63eb2) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jul 6, 2024
… to activate/deactivate source (#1068) (#1075) * added url_download type of threat intel source; activate/deactivate for sources * added check for controls --------- (cherry picked from commit 6b63eb2) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we are adding support to display threat intel sources that use URL to download the IoC data. It also, integrates the Activate/Deactivate capability for threat intel sources. Deactivating a source will stop the refresh schedule and the source's use in threat intel scan.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.