Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create detector refactor alert triggers per mocks #503

Conversation

jovancacvetkovic
Copy link
Contributor

Description

Implements new mocks for alert triggers during the detector creation process.

Issues Resolved

Resolves #498

Screenshots

screencapture-localhost-5601-app-opensearch-security-analytics-dashboards-2023-04-07-13_23_21
screencapture-localhost-5601-app-opensearch-security-analytics-dashboards-2023-04-07-13_24_36
screencapture-localhost-5601-app-opensearch-security-analytics-dashboards-2023-04-07-13_24_52
screencapture-localhost-5601-app-opensearch-security-analytics-dashboards-2023-04-07-13_25_09
Screenshot from 2023-04-07 13-22-35

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…oject#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…rch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…rch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…rch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
@jovancacvetkovic jovancacvetkovic requested a review from a team April 7, 2023 12:02
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Merging #503 (899c724) into main (24c8ec2) will decrease coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   35.58%   35.55%   -0.04%     
==========================================
  Files         121      121              
  Lines        3428     3440      +12     
  Branches      596      601       +5     
==========================================
+ Hits         1220     1223       +3     
- Misses       2073     2081       +8     
- Partials      135      136       +1     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jovancacvetkovic jovancacvetkovic changed the title Create detector refactor alert triggers per mocks #498 Create detector refactor alert triggers per mocks Apr 7, 2023
…-analytics-dashboards-plugin into Create_detector_Refactor_alert_triggers_per_mocks_#498

# Conflicts:
#	public/pages/CreateDetector/utils/constants.ts
…-analytics-dashboards-plugin into Create_detector_Refactor_alert_triggers_per_mocks_#498

# Conflicts:
#	cypress/integration/1_detectors.spec.js
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
@amsiglan amsiglan merged commit cb8c0a0 into opensearch-project:main Apr 12, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-503-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cb8c0a0757e1ce05f624d284e613c74948f884ce
# Push it to GitHub
git push --set-upstream origin backport/backport-503-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-503-to-2.x.

amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this pull request Apr 12, 2023
…#503)

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Create detector refactor alert triggers per mocks
opensearch-project#503

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
amsiglan added a commit that referenced this pull request Apr 17, 2023
* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495



* [FEATURE] Create global state object for async requests #493



* [FEATURE] Create detector \ Refactor alert triggers per mocks #498



* [FEATURE] Create detector \ Refactor alert triggers per mocks #498



* [FEATURE] Create detector \ Refactor alert triggers per mocks #498



* Create detector refactor alert triggers per mocks
#503



* Update detector details component #504



---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…#503) (opensearch-project#514)

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495



* [FEATURE] Create global state object for async requests opensearch-project#493



* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498



* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498



* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498



* Create detector refactor alert triggers per mocks
opensearch-project#503



* Update detector details component opensearch-project#504



---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create detector \ Refactor alert triggers per mocks
4 participants