Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match maintainer username. #591

Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented May 18, 2023

Description

Same as opensearch-project/security-analytics#438.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member Author

dblock commented Sep 14, 2023

Could one of the maintainers please merge this PR that has been open since May?
@lezzago @sbcd90 @AWSHurneyt @eirsep @praveensameneni @amsiglan @getsaurabh02

Signed-off-by: dblock <dblock@amazon.com>
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #591 (345af69) into main (b72d1a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #591   +/-   ##
=======================================
  Coverage   31.49%   31.49%           
=======================================
  Files         150      150           
  Lines        4814     4814           
  Branches      803      803           
=======================================
  Hits         1516     1516           
  Misses       3119     3119           
  Partials      179      179           

@AWSHurneyt AWSHurneyt merged commit b8b3298 into opensearch-project:main Sep 15, 2023
9 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-591-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b8b32981862f71a405949d21cece7d08799e6c40
# Push it to GitHub
git push --set-upstream origin backport/backport-591-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-591-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants