Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text area ux and add expression UI #603

Closed
wants to merge 8 commits into from
Closed

Improve text area ux and add expression UI #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
db72f43
[FEATURE] Improve "list" text area UX #589
jovancacvetkovic May 29, 2023
0ae5a7e
[FEATURE] Improve "list" text area UX #589
jovancacvetkovic May 29, 2023
7ffa636
[FEATURE] Improve "list" text area UX #589
jovancacvetkovic May 30, 2023
3dd40db
[FEATURE] Improve "list" text area UX #589
jovancacvetkovic May 30, 2023
50eab7c
[FEATURE] Replace code editor with expression editor #602
jovancacvetkovic Jun 1, 2023
a3cdcf1
[FEATURE] Replace code editor with expression editor #602
jovancacvetkovic Jun 1, 2023
7ecf906
Merge branch 'main' of https://github.com/opensearch-project/security…
jovancacvetkovic Jun 1, 2023
36aab7e
Improve text area ux and add expression UI #603
jovancacvetkovic Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cypress/integration/2_rules.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ describe('Rules', () => {
cy.get('[data-test-subj="rule_author_field"]').type(`${SAMPLE_RULE.author}{enter}`);

cy.get('[data-test-subj="detection-visual-editor-0"]').within(() => {
cy.getFieldByLabel('Name').type('{selectall}{backspace}').type('Selection_1');
cy.getFieldByLabel('Key').type('Provider_Name');
cy.getInputByPlaceholder('Value').type('Service Control Manager');

Expand All @@ -201,6 +202,11 @@ describe('Rules', () => {
force: true,
});

cy.get('[aria-label="Add one more condition"]').click({ force: true });

// Enter the author
cy.get('[data-test-subj="rule_author_field"]').type(`${SAMPLE_RULE.author}`);

// Switch to YAML editor
cy.get('[data-test-subj="change-editor-type"] label:nth-child(2)').click({
force: true,
Expand Down
1 change: 1 addition & 0 deletions public/app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ $euiTextColor: $euiColorDarkestShade !default;
@import "./pages/Findings/components/CorrelationsTable/CorrelationsTable.scss";
@import "./pages/Rules/components/RuleEditor/RuleEditorForm.scss";
@import "./pages/Rules/components/RuleEditor/DetectionVisualEditor.scss";
@import "./pages/Rules/components/RuleEditor/components/SelectionExpField.scss";

.selected-radio-panel {
background-color: tintOrShade($euiColorPrimary, 90%, 70%);
Expand Down
Loading
Loading