[Backport 2.x] Added support for editing correlation rule #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* added support for editing correlation rule Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed query deletion; api method Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * removed logs Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed rule expression builder Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 0fee0e8)
amsiglan
approved these changes
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #645 +/- ##
==========================================
- Coverage 32.66% 32.51% -0.15%
==========================================
Files 139 139
Lines 4491 4527 +36
Branches 750 748 -2
==========================================
+ Hits 1467 1472 +5
- Misses 2847 2878 +31
Partials 177 177 |
AWSHurneyt
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0fee0e8 from #643