-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make notifications optional #796
Make notifications optional #796
Conversation
* Threat intel feed support for detector creation (opensearch-project#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
+ Coverage 31.14% 31.18% +0.03%
==========================================
Files 151 151
Lines 5005 4999 -6
Branches 857 855 -2
==========================================
Hits 1559 1559
+ Misses 3255 3250 -5
+ Partials 191 190 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
.../CreateDetector/components/ConfigureAlerts/components/AlertCondition/AlertConditionPanel.tsx
Show resolved
Hide resolved
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-796-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5bf43a624f4563d53120c277773972722c3fa9f2
# Push it to GitHub
git push --set-upstream origin backport/backport-796-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* Make notifications optional 2.11 (opensearch-project#770) * Threat intel feed support for detector creation (opensearch-project#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * revert notification change Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
* Make notifications optional (#796) * Make notifications optional 2.11 (#770) * Threat intel feed support for detector creation (#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * revert notification change Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * supporting array of key/value under selection (#803) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Correlation rules field matching and time window support (#804) * added ux for group by field and time window Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * improved validation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * check for null values Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * validate fields only when group by enabled; update default window to 5 min (#810) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * do not send fields if empty (#817) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Allow empty field name for supporting timeframe and keywords when validating rule during creation/update (#823) * allow empty field name for supporting timeframe and keywords Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed update payload (#838) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * add already mapped log index fields to list of options (#845) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
* Make notifications optional 2.11 (opensearch-project#770) * Threat intel feed support for detector creation (opensearch-project#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * revert notification change Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
* Make notifications optional (#796) * Make notifications optional 2.11 (#770) * Threat intel feed support for detector creation (#762) * added threat intel feed support for detector creation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated cypress workflow file Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated alerts; findings UX Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * refactored alert condition panel; update detector for intel feeds Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshots, mocks Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated workflow Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated snapshot Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated UI; tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed tests; make notification optional Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * revert notification change Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * supporting array of key/value under selection (#803) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Correlation rules field matching and time window support (#804) * added ux for group by field and time window Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * improved validation Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * check for null values Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * validate fields only when group by enabled; update default window to 5 min (#810) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * do not send fields if empty (#817) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Allow empty field name for supporting timeframe and keywords when validating rule during creation/update (#823) * allow empty field name for supporting timeframe and keywords Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed update payload (#838) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Description
Forward porting changes from #770 to keep Notifications optional in detector creation workflow since there is a possibility that Notification backend plugin exists but not the frontend plugin in which case the user won't be able to create a channel and thus cannot create a detector
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.