Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correlation rules field matching and time window support #804

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Correlation rules field matching and time window support #804

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d080fc
added ux for group by field and time window
amsiglan Nov 29, 2023
bd5abf2
improved validation
amsiglan Nov 29, 2023
f3b77ed
check for null values
amsiglan Nov 29, 2023
ece4266
Merge remote-tracking branch 'opensearch/main' into correlation-rules…
amsiglan Nov 29, 2023
818170e
addressed PR comments
amsiglan Nov 30, 2023
1b923ba
resolved conflicts
amsiglan Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/components/ContentPanel/ContentPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const renderSubTitleText = (subTitleText: string | JSX.Element): JSX.Element | n
return subTitleText;
};

const ContentPanel: React.SFC<ContentPanelProps> = ({
const ContentPanel = ({
title = '',
titleSize = 'm',
subTitleText = '',
Expand All @@ -48,7 +48,7 @@ const ContentPanel: React.SFC<ContentPanelProps> = ({
children,
hideHeaderBorder = false,
className = '',
}) => (
}: ContentPanelProps): JSX.Element => (
<EuiPanel
style={{ paddingLeft: '0px', paddingRight: '0px', ...panelStyles }}
className={className}
Expand Down
4 changes: 2 additions & 2 deletions public/components/FormFieldHeader/FormFieldHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ export interface FormFieldHeaderProps {
toolTipText?: string;
}

export const FormFieldHeader: React.FC<FormFieldHeaderProps> = ({
export const FormFieldHeader = ({
headerTitle = '',
optionalField = false,
toolTipIconType = 'questionInCircle',
toolTipPosition = 'top',
toolTipText = '',
}) => {
}: FormFieldHeaderProps): JSX.Element => {
return (
<EuiText size={'s'}>
<strong>{headerTitle}</strong>
Expand Down
3 changes: 3 additions & 0 deletions public/pages/Correlations/containers/CorrelationRuleFormModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { CorrelationRuleModel } from '../../../../types';

export const correlationRuleStateDefaultValue: CorrelationRuleModel = {
name: '',
time_window: 60000,
queries: [
{
logType: '',
Expand All @@ -18,6 +19,7 @@ export const correlationRuleStateDefaultValue: CorrelationRuleModel = {
},
],
index: '',
field: '',
},
{
logType: '',
Expand All @@ -29,6 +31,7 @@ export const correlationRuleStateDefaultValue: CorrelationRuleModel = {
},
],
index: '',
field: '',
},
],
};
Loading
Loading