Update actions menu after start/stop detector action for the selected detector #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
amsiglan
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
==========================================
- Coverage 31.05% 31.04% -0.01%
==========================================
Files 157 157
Lines 5230 5234 +4
Branches 981 982 +1
==========================================
+ Hits 1624 1625 +1
- Misses 3419 3422 +3
Partials 187 187 ☔ View full report in Codecov by Sentry. |
eirsep
requested changes
Feb 15, 2024
Yes working on adding tests |
…u-after-action-detectors-table
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Added cypress test for the toggle button |
riysaxen-amzn
approved these changes
Mar 13, 2024
AWSHurneyt
approved these changes
Mar 13, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
eirsep
approved these changes
Mar 14, 2024
amsiglan
added
backport 2.x
backport 2.11
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
… detector (#895) * updated selected items state after action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added cypress test for detector toggle action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * simplified code Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 8e2ae0a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
… detector (#895) * updated selected items state after action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added cypress test for detector toggle action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * simplified code Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 8e2ae0a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
… detector (#895) * updated selected items state after action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added cypress test for detector toggle action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * simplified code Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 8e2ae0a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
added a commit
that referenced
this pull request
Mar 16, 2024
… detector (#895) (#928) * updated selected items state after action * added cypress test for detector toggle action * simplified code --------- (cherry picked from commit 8e2ae0a) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 16, 2024
… detector (#895) * updated selected items state after action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added cypress test for detector toggle action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * simplified code Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 8e2ae0a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
added a commit
that referenced
this pull request
Apr 10, 2024
…or the selected detector (#957) * Update actions menu after start/stop detector action for the selected detector (#895) * updated selected items state after action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added cypress test for detector toggle action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * simplified code Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 8e2ae0a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fixed cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
added a commit
that referenced
this pull request
Apr 10, 2024
…for the selected detector (#930) * Update actions menu after start/stop detector action for the selected detector (#895) * updated selected items state after action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added cypress test for detector toggle action Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * simplified code Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 8e2ae0a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fixed cypress test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a detector is stopped using the action menu in the Detectors table, the action menu does not update for the selected item i.e. the menu item still says
Stop detectoreven though the detector is stopped.This PR fixes the issue by updating the selected items state maintained in the Detectors components after the action is complete and we load the updated list of detectors.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.