Fixed view surrounding logs for aliases #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep and
riysaxen-amzn
as code owners
riysaxen-amzn
approved these changes
Mar 8, 2024
…logs-fix-for-aliases
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
=======================================
Coverage 31.05% 31.05%
=======================================
Files 157 157
Lines 5230 5230
Branches 981 981
=======================================
Hits 1624 1624
Misses 3419 3419
Partials 187 187 ☔ View full report in Codecov by Sentry. |
AWSHurneyt
approved these changes
Mar 14, 2024
amsiglan
added
backport 2.x
backport 2.10
backport 2.11
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit d7ded8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit d7ded8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit d7ded8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit d7ded8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Mar 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit d7ded8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Mar 14, 2024
(cherry picked from commit d7ded8a) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Mar 14, 2024
(cherry picked from commit d7ded8a) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Mar 14, 2024
(cherry picked from commit d7ded8a) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
added a commit
that referenced
this pull request
Mar 16, 2024
(cherry picked from commit d7ded8a) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
added a commit
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit d7ded8a) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using an alias to create a detector, it abstracts away the actual index from which the documents are searched for generating finding. However, the finding returns the actual index name and hence when creating index pattern for showing surrounding logs we need to use the data source name stored in the finding and not the detector config because that would give us the alias name which won't work in the Discover plugin surrounding docs page
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.