You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order to detect the breaking changes between OpenSearch (core/min) and plugins, we recently onboarded a compatibility check gradle task with OpenSearch. See the pull request.
The task is dependent on publishToMavenLocal task (that publishes the core engine artifacts to maven local). It then clones the plugins' repository in temporary directory and runs ./gradlew assemble.
Action Items
In order to avoid false positives and false negatives, we need to make sure the tasks in below checklist are complete:
The build.gradle file in this repository uses mavenLocal() as the first entry in repositories() section. This will ensure that when core/min dependencies are published to maven local, gradle looks at maven local first and gets the required core/min dependencies rather than fetching from snapshots or maven central resulting in false checks.
./gradlew assemble task passes for the plugin build. If the task itself is broken, checking compatitibility is irrelevant as it will always fail.
Please close this issue once the above checklist is complete.
Thanks!
The text was updated successfully, but these errors were encountered:
…rch-project#499)
As per gradle [docs] add support to remove timestamps and package with same order which is required from
[reproducible] builds
[docs]: https://docs.gradle.org/current/userguide/working_with_files.html#sec:archives
[reproducible]: https://reproducible-builds.org/
Signed-off-by: Leonidas Spyropoulos <artafinde@archlinux.org>
(cherry picked from commit a27d5a214f2bcd9101e7602d715d17592ccd5e0f)
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Co-authored-by: Leonidas Spyropoulos <artafinde@gmail.com>
Coming from opensearch-project/opensearch-devops#114 (comment)
Overview
In order to detect the breaking changes between OpenSearch (core/min) and plugins, we recently onboarded a compatibility check gradle task with OpenSearch. See the pull request.
The task is dependent on
publishToMavenLocal
task (that publishes the core engine artifacts to maven local). It then clones the plugins' repository in temporary directory and runs./gradlew assemble
.Action Items
In order to avoid false positives and false negatives, we need to make sure the tasks in below checklist are complete:
mavenLocal()
as the first entry inrepositories()
section. This will ensure that when core/min dependencies are published to maven local, gradle looks at maven local first and gets the required core/min dependencies rather than fetching from snapshots or maven central resulting in false checks../gradlew assemble
task passes for the plugin build. If the task itself is broken, checking compatitibility is irrelevant as it will always fail.Please close this issue once the above checklist is complete.
Thanks!
The text was updated successfully, but these errors were encountered: