Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update index monitor method to include namedWriteableRegistry for common utils interface #101

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Nov 3, 2022

Changes method to use update from opensearch-project/common-utils#304

Signed-off-by: Surya Sashank Nistala snistala@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…mon utils interface

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #101 (0d9ff8d) into main (6f7468b) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #101      +/-   ##
============================================
- Coverage     43.22%   43.16%   -0.06%     
+ Complexity      859      858       -1     
============================================
  Files           167      167              
  Lines          5826     5829       +3     
  Branches        734      734              
============================================
- Hits           2518     2516       -2     
- Misses         3076     3080       +4     
- Partials        232      233       +1     
Impacted Files Coverage Δ
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)
...g/opensearch/securityanalytics/model/Detector.java 70.54% <0.00%> (-0.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit 7de91b5 into opensearch-project:main Nov 3, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-101-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7de91b5dd37dcdbea13e76bb20c6c449f7bfda34
# Push it to GitHub
git push --set-upstream origin backport/backport-101-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-101-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 3, 2022
…mon utils interface (#101)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 7de91b5)
eirsep added a commit that referenced this pull request Nov 3, 2022
…mon utils interface (#101) (#103)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
(cherry picked from commit 7de91b5)

Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
@eirsep eirsep deleted the fix branch November 3, 2022 02:28
eirsep added a commit to eirsep/security-analytics that referenced this pull request Nov 3, 2022
…mon utils interface (opensearch-project#101)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep added a commit that referenced this pull request Nov 3, 2022
…mon utils interface (#101) (#105)

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
…us buttons when executing API calls. (opensearch-project#101)

* Fixed bug that prevented setting a detector description.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed an issue that was limiting the number of detectors returned when calling the SearchDetector backend API.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed an issue that was preventing the data source combo box from being cleared when editing a detector. Removed unused imports.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Made save button on rules edit page filled.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed the link to the detector details page on the FindingDetailsFlyout when opening the flyout from the AlertFlyout.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed an issue that was preventing the recent time selections from rendering in the SuperTimePicker. This also fixed the issue that was causing the "update" text on the refresh button from changing back to "refresh" after loading.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adjusted the display time for toasts.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Fixed the display of the findings count in the alert details flyout. fixed the format of the findings' log types in the table, and the alert status.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Disabled buttons depending on whether the component is executing an API call.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Disabled buttons depending on whether the component is executing an API call.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Disabled buttons depending on whether the component is executing an API call.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants