Threat Intel Feed Config Model #1028
Conversation
jowg-amazon
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
engechas,
goyamegh and
riysaxen-amzn
as code owners
| import java.util.Locale; | ||
| import java.util.Map; | ||
|
|
||
| public class SATIFConfig implements TIFConfig, Writeable, ScheduledJobParameter { |
There was a problem hiding this comment.
added javadocs
| public Instant lastRefreshedTime; | ||
| public String lastRefreshedUser; | ||
| private Boolean isEnabled; | ||
| private Map<String, Object> iocMapStore; |
There was a problem hiding this comment.
This is the map that shows where we are storing the IOCs per feed. For opensearch it would be something like Map: Ip: , DNS:
| ); | ||
| } | ||
|
|
||
| public static TIFJobState toState(String stateName) { |
There was a problem hiding this comment.
The states are an enum, changed the function to use switch case
There was a problem hiding this comment.
this is not scalable
use valueOf(String name) which returns enum and wrap with try catch where catch returns null and logs error that couldnt parse enum
There was a problem hiding this comment.
Changed it to use valueOf
| import java.util.Map; | ||
|
|
||
| /** | ||
| * Threat intel config interface |
There was a problem hiding this comment.
can we rename entity to TIFSource Config
There was a problem hiding this comment.
renamed to TIFSourceConfig
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
jowg-amazon
force-pushed
the
threat_intel_TIFConfig
branch
from
e4e78e0
to
3fd7f89
Compare
Signed-off-by: Joanne Wang <jowg@amazon.com>
| private Long version; | ||
| private String feedName; | ||
| private String feedFormat; | ||
| private Boolean prepackaged; |
There was a problem hiding this comment.
let's have feed type instead of this
LICENSED
OPEN-SOURCED
CUSTOM
INTERNAL
There was a problem hiding this comment.
added enum class for these fields
| @@ -33,5 +33,10 @@ public enum TIFJobState { | |||
| /** | |||
| * tif job is being deleted | |||
| */ | |||
| DELETING | |||
| DELETING, | |||
There was a problem hiding this comment.
Added REFRESHING as a state
Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Joanne Wang <jowg@amazon.com>
jowg-amazon
merged commit a99ca4d
into
opensearch-project:feature/threat_intel
Description
Files changed outside of refactoring:
threat_intel_job_mapping.jsonTIFConfigTIFConfigDtoSATIFConfigSATIFConfigDtoTIFJobStateIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.