Rough draft of IOC data model. #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested changes
May 17, 2024
@eirsep Added some basic validation. |
AWSHurneyt
requested review from
amsiglan,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
jowg-amazon
reviewed
May 20, 2024
src/main/java/org/opensearch/securityanalytics/model/IocDao.java
Outdated
Show resolved
Hide resolved
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
force-pushed
the
3.0-threat-intel
branch
from
72a75ab
to
8727d3c
Compare
eirsep
reviewed
May 24, 2024
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@eirsep Added some unit tests. Will add more once we're more confident that this is the final structure of the data model. |
eirsep
approved these changes
May 28, 2024
eirsep
merged commit 26f9b0c
into
opensearch-project:feature/threat_intel
2 checks passed
eirsep
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Rough draft of IOC data model. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed IOC value from a list to a string. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added validation for IOC type, value, and feedId fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored IocType to for ipv4, and ipv6. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored IocType. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
jowg-amazon
pushed a commit
to jowg-amazon/security-analytics
that referenced
this pull request
Jun 4, 2024
* Rough draft of IOC data model. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed IOC value from a list to a string. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added validation for IOC type, value, and feedId fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored IocType to for ipv4, and ipv6. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored IocType. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
eirsep
pushed a commit
to eirsep/security-analytics
that referenced
this pull request
Jun 6, 2024
* Rough draft of IOC data model. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed IOC value from a list to a string. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added validation for IOC type, value, and feedId fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored IocType to for ipv4, and ipv6. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored IocType. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
eirsep
pushed a commit
that referenced
this pull request
Jun 6, 2024
* Rough draft of IOC data model. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed IOC value from a list to a string. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added validation for IOC type, value, and feedId fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored IocType to for ipv4, and ipv6. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored IocType. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
added a commit
to AWSHurneyt/security-analytics
that referenced
this pull request
Jun 25, 2024
* Rough draft of IOC data model. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed IOC value from a list to a string. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added validation for IOC type, value, and feedId fields. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored IocType to for ipv4, and ipv6. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored IocType. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are the references I'm using.
Domain documentation
Section "6.4 Domain Name Object" of https://docs.oasis-open.org/cti/stix/v2.1/os/stix-v2.1-os.html#_k017w16zutw
Hash documentation
https://stix2.readthedocs.io/en/latest/guide/serializing.html
IP documentation
"6.8 IPv4 Address Object" section of https://docs.oasis-open.org/cti/stix/v2.1/os/stix-v2.1-os.html#_wh296fiwpklp
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.