[Backport 2.15] Adjusted IOCTypes usage. (#1156) #1159
Merged
+528
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed TODOs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored how STIX2IOCGenerator creates IOCs of specific types. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added additional integration tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed IOCType usage as it's no longer an enum in SA commons. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated jar file. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed unit tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Refactored build.gradle to exclude redundant dependencies from SA commons, instead of the SA commons jar being generated withhout those dependencies. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated jar. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Reverted changes to build.gradle. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Updated jar. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed IOCType usage. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed log message. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed tests. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Addressed PR feedback. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit a6eb64d) Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
requested review from
amsiglan,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
jowg-amazon
approved these changes
Jul 12, 2024
eirsep
approved these changes
Jul 12, 2024
|
This PR covers PR #1158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of PR #1156.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.