update build.gradle to use alerting-spi snapshot version #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
sbcd90
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
eirsep
requested changes
Aug 5, 2024
| @@ -168,7 +171,7 @@ dependencies { | |||
| compileOnly "org.opensearch.client:opensearch-rest-client:${opensearch_version}" | |||
| compileOnly "org.jetbrains.kotlin:kotlin-stdlib:${kotlin_version}" | |||
| compileOnly "org.opensearch:opensearch-job-scheduler-spi:${opensearch_build}" | |||
| compileOnly "org.opensearch.alerting:alerting-spi:${opensearch_build}" | |||
| compileOnly "org.opensearch.alerting:alerting-spi:${alerting_spi_build}" | |||
There was a problem hiding this comment.
why is it not similar to the job scheduler spi??
There was a problem hiding this comment.
plz match the naming convention version of the alerting spi to job scheduler spi
74 tasks
goyamegh
reviewed
Aug 5, 2024
| @@ -18,6 +18,9 @@ buildscript { | |||
| if (buildVersionQualifier) { | |||
| opensearch_build += "-${buildVersionQualifier}" | |||
| } | |||
|
|
|||
| alerting_spi_build = opensearch_build | |||
| alerting_spi_build += "-SNAPSHOT" | |||
There was a problem hiding this comment.
Aren't we supposed to pick from the non-released versions, like we do with the main alerting repo today?
There was a problem hiding this comment.
This should be pulled from the snapshot repo, example https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/alerting/alerting-spi/2.16.0.0-SNAPSHOT/.
AWSHurneyt
approved these changes
Aug 5, 2024
eirsep
approved these changes
Aug 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit ddfa87c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit ddfa87c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Aug 5, 2024
(cherry picked from commit ddfa87c) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update build.gradle to use alerting-spi snapshot version
Issues Resolved
#1193
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.