Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to support https as param for security integ tests #156

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Nov 12, 2022

Signed-off-by: Subhobrata Dey sbcd90@gmail.com

Description

this PR removes the dependency on security setting & adds dependency on https setting as opensearch-build uses it now. https://github.com/opensearch-project/opensearch-build/blob/main/scripts/default/integtest.sh#L98

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@sbcd90 sbcd90 requested a review from a team November 12, 2022 02:59
@codecov-commenter
Copy link

Codecov Report

Merging #156 (fb33a43) into main (2e44ff4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #156   +/-   ##
=========================================
  Coverage     39.06%   39.06%           
  Complexity      891      891           
=========================================
  Files           176      176           
  Lines          6724     6724           
  Branches        820      820           
=========================================
  Hits           2627     2627           
  Misses         3856     3856           
  Partials        241      241           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit 7d07189 into opensearch-project:main Nov 14, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 14, 2022
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit 7d07189)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 14, 2022
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
(cherry picked from commit 7d07189)
sbcd90 pushed a commit that referenced this pull request Nov 14, 2022
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
sbcd90 pushed a commit that referenced this pull request Nov 14, 2022
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Feb 20, 2024
…ch-project#156 (opensearch-project#194)

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants