Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search returns detector type in CAPS fix and integration tests #174

Merged
merged 5 commits into from
Dec 30, 2022

Conversation

raj-chak
Copy link
Contributor

@raj-chak raj-chak commented Dec 1, 2022

Signed-off-by: Raj Chakravarthi raj@icedome.ca

Description

After this change, the detector type will be returned in small case during search.
Also, integration tests are written to ensure that happens in create, update, get , search detector.

Issues Resolved

(#173)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
@raj-chak raj-chak requested a review from a team December 1, 2022 19:56
Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #174 (57b8640) into main (a4a542d) will decrease coverage by 0.12%.
The diff coverage is 44.00%.

@@             Coverage Diff              @@
##               main     #174      +/-   ##
============================================
- Coverage     39.06%   38.94%   -0.13%     
  Complexity      891      891              
============================================
  Files           176      176              
  Lines          6724     6746      +22     
  Branches        820      823       +3     
============================================
  Hits           2627     2627              
- Misses         3856     3877      +21     
- Partials        241      242       +1     
Impacted Files Coverage Δ
...rch/securityanalytics/action/IndexRuleRequest.java 0.00% <0.00%> (ø)
...yanalytics/transport/TransportGetAlertsAction.java 0.00% <ø> (ø)
...nalytics/transport/TransportGetFindingsAction.java 0.00% <0.00%> (ø)
...yanalytics/transport/TransportIndexRuleAction.java 0.00% <0.00%> (ø)
...alytics/config/monitors/DetectorMonitorConfig.java 53.84% <31.25%> (ø)
...rch/securityanalytics/mapper/MapperTopicStore.java 77.77% <100.00%> (ø)
...g/opensearch/securityanalytics/model/Detector.java 69.89% <100.00%> (-0.70%) ⬇️
...earch/securityanalytics/model/DetectorTrigger.java 56.14% <100.00%> (+0.51%) ⬆️
...opensearch/securityanalytics/util/RuleIndices.java 0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
@eirsep
Copy link
Member

eirsep commented Dec 2, 2022

It's fine to return smallcase in response but we should be able to handle case agnostic input from client

Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
@sbcd90 sbcd90 merged commit 1770873 into opensearch-project:main Dec 30, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 30, 2022
Signed-off-by: Raj Chakravarthi <raj@icedome.ca>
(cherry picked from commit 1770873)
sbcd90 pushed a commit that referenced this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants