fix for input validation of correlation rule names #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #428 +/- ##
============================================
- Coverage 28.23% 28.19% -0.05%
+ Complexity 897 896 -1
============================================
Files 231 231
Lines 9318 9326 +8
Branches 1073 1074 +1
============================================
- Hits 2631 2629 -2
- Misses 6451 6460 +9
- Partials 236 237 +1
|
getsaurabh02
previously approved these changes
May 6, 2023
lezzago
previously approved these changes
May 8, 2023
| @@ -25,6 +30,8 @@ public class IndexCorrelationRuleRequest extends ActionRequest { | |||
|
|
|||
| private RestRequest.Method method; | |||
|
|
|||
| private static final Pattern REGEX = Pattern.compile("[a-zA-Z0-9 _,-.]{5,50}"); | |||
There was a problem hiding this comment.
Should we rename this variable to something more readable? Maybe: IS_VALID_RULE_NAME?
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
lezzago
approved these changes
May 8, 2023
getsaurabh02
approved these changes
May 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 8, 2023
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit cc53260)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 8, 2023
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> (cherry picked from commit cc53260)
sbcd90
pushed a commit
that referenced
this pull request
May 8, 2023
sbcd90
pushed a commit
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix for input validation of correlation rule names
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.