Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using alerting workflows in detectors (#394) #533

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Sep 5, 2023

Enables workflow creation - all the monitors related with the given detector will be part of the detector Enables workflow update during detector update
Deletes the workflow during the detector deletion
Adds additional field to a detector

Enables workflow creation - all the monitors related with the given detector will be part of the detector
Enables workflow update during detector update
Deletes the workflow during the detector deletion
Adds additional field to a detector

Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
…isabled flag

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #533 (3f8b767) into main (4d63f38) will decrease coverage by 0.29%.
The diff coverage is 2.43%.

❗ Current head 3f8b767 differs from pull request most recent head 596fe66. Consider uploading reports for the commit 596fe66 to get more accurate results

@@             Coverage Diff              @@
##               main     #533      +/-   ##
============================================
- Coverage     25.72%   25.43%   -0.29%     
- Complexity      938      943       +5     
============================================
  Files           252      254       +2     
  Lines         10768    10933     +165     
  Branches       1197     1205       +8     
============================================
+ Hits           2770     2781      +11     
- Misses         7749     7901     +152     
- Partials        249      251       +2     
Files Changed Coverage Δ
...rch/securityanalytics/SecurityAnalyticsPlugin.java 2.43% <ø> (ø)
...ytics/transport/TransportDeleteDetectorAction.java 0.00% <0.00%> (ø)
...nalytics/transport/TransportGetFindingsAction.java 0.00% <ø> (ø)
...lytics/transport/TransportIndexDetectorAction.java 0.00% <0.00%> (ø)
...nsearch/securityanalytics/util/MonitorService.java 0.00% <0.00%> (ø)
...search/securityanalytics/util/WorkflowService.java 0.00% <0.00%> (ø)
...g/opensearch/securityanalytics/model/Detector.java 65.73% <35.00%> (-0.69%) ⬇️
...yanalytics/settings/SecurityAnalyticsSettings.java 96.00% <100.00%> (+0.16%) ⬆️

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Copy link
Collaborator

@sbcd90 sbcd90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eirsep eirsep merged commit 1cb5ddc into opensearch-project:main Sep 6, 2023
11 of 13 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-533-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1cb5ddc79d8a76ad722997f48d7c57f203c56d8a
# Push it to GitHub
git push --set-upstream origin backport/backport-533-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-533-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants