-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using alerting workflows in detectors (#394) #533
Conversation
Enables workflow creation - all the monitors related with the given detector will be part of the detector Enables workflow update during detector update Deletes the workflow during the detector deletion Adds additional field to a detector Signed-off-by: Stevan Buzejic <buzejic.stevan@gmail.com>
…isabled flag Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #533 +/- ##
============================================
- Coverage 25.72% 25.43% -0.29%
- Complexity 938 943 +5
============================================
Files 252 254 +2
Lines 10768 10933 +165
Branches 1197 1205 +8
============================================
+ Hits 2770 2781 +11
- Misses 7749 7901 +152
- Partials 249 251 +2
|
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr looks good. approving the pr. but we need to work on the bucket-level trigger impl
. https://github.com/opensearch-project/security-analytics/pull/533/files#diff-8fa8978eef6244554fff1512eb4ed63755d995cf3e8aa295522657a4eecb6166R775
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-533-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1cb5ddc79d8a76ad722997f48d7c57f203c56d8a
# Push it to GitHub
git push --set-upstream origin backport/backport-533-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Enables workflow creation - all the monitors related with the given detector will be part of the detector Enables workflow update during detector update
Deletes the workflow during the detector deletion
Adds additional field to a detector