Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* #709 Return empty response for empty mappings and no applied aliases #765

Merged

Conversation

goyamegh
Copy link
Collaborator

@goyamegh goyamegh commented Dec 1, 2023

Description

Returns an empty response instead of exception in case of:

  1. empty index mappings are present,
  2. no applied aliases are present on the index

Issues Resolved

#709

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… no applied aliases

Signed-off-by: Megha Goyal <goyamegh@amazon.com>

* Adding integ tests for empty mappings/aliases use-cases

Signed-off-by: Megha Goyal <goyamegh@amazon.com>

* Fix unit tests for MappingsTraverser

Signed-off-by: Megha Goyal <goyamegh@amazon.com>

---------

Signed-off-by: Megha Goyal <goyamegh@amazon.com>
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cd23067) 28.17% compared to head (456ce10) 28.13%.

Files Patch % Lines
...ch/securityanalytics/mapper/MappingsTraverser.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.7     #765      +/-   ##
============================================
- Coverage     28.17%   28.13%   -0.04%     
  Complexity      895      895              
============================================
  Files           231      231              
  Lines          9343     9343              
  Branches       1075     1075              
============================================
- Hits           2632     2629       -3     
- Misses         6474     6477       +3     
  Partials        237      237              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goyamegh goyamegh marked this pull request as ready for review December 8, 2023 23:07
@jowg-amazon jowg-amazon merged commit 830a3b9 into opensearch-project:2.7 Dec 14, 2023
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants