Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ArrayIndexOutOfBoundsException for inconsistent detector index behavior #843

Merged
merged 3 commits into from
Feb 14, 2024
Merged

[BUG] ArrayIndexOutOfBoundsException for inconsistent detector index behavior #843

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e8a222
Catch ArrayIndexOutOfBoundsException when detector is missing
goyamegh Feb 8, 2024
2a1b7e0
Add a check on SearchHits.getHits() length
goyamegh Feb 8, 2024
6f852a3
Remove index out of bounds exception
goyamegh Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...main/java/org/opensearch/securityanalytics/transport/TransportCorrelateFindingAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,8 @@
}

SearchHits hits = response.getHits();
if (hits.getTotalHits().value == 1) {
// Detectors Index hits count could be more even if we fetch one
Copy link
Member

@eirsep eirsep Feb 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious why can hits be >1 ??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it >1 in case we remove filters and the number of hits are more than 1.

if (hits.getTotalHits().value >= 1 && hits.getHits().length > 0) {
try {
SearchHit hit = hits.getAt(0);

Expand All @@ -272,6 +273,7 @@
Detector detector = Detector.docParse(xcp, hit.getId(), hit.getVersion());
joinEngine.onSearchDetectorResponse(detector, finding);
} catch (IOException e) {
log.error("IOException for request {}", searchRequest.toString(), e);

Check warning on line 276 in src/main/java/org/opensearch/securityanalytics/transport/TransportCorrelateFindingAction.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/securityanalytics/transport/TransportCorrelateFindingAction.java#L276 

Added line #L276 was not covered by tests
onFailures(e);
}
} else {
Expand Down
Loading