add mappings and test case #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, Can we fix the dco and build failures. |
phaseshiftg
force-pushed
the
mappings_with_test
branch
2 times, most recently
from
c7d9594
to
f253867
Compare
|
I believe all the mappings are now present aside from windows and ad_ldap |
phaseshiftg
force-pushed
the
mappings_with_test
branch
3 times, most recently
from
c3c58f6
to
f3252b9
Compare
Signed-off-by: Grant Haywood <grant@phaseshift.studio>
phaseshiftg
force-pushed
the
mappings_with_test
branch
from
f3252b9
to
87aa33c
Compare
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
============================================
- Coverage 39.97% 39.96% -0.01%
Complexity 882 882
============================================
Files 175 175
Lines 6436 6435 -1
Branches 786 786
============================================
- Hits 2573 2572 -1
Misses 3626 3626
Partials 237 237
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Grant Haywood <grant@phaseshift.studio>
eirsep
approved these changes
Nov 9, 2022
sbcd90
approved these changes
Nov 9, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
* dns and cloudtrail mappings Signed-off-by: Grant Haywood <grant@phaseshift.studio> * add s3 mappings Signed-off-by: Grant Haywood <grant@phaseshift.studio> Signed-off-by: Grant Haywood <grant@phaseshift.studio> (cherry picked from commit ee7f6fb)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
* dns and cloudtrail mappings Signed-off-by: Grant Haywood <grant@phaseshift.studio> * add s3 mappings Signed-off-by: Grant Haywood <grant@phaseshift.studio> Signed-off-by: Grant Haywood <grant@phaseshift.studio> (cherry picked from commit ee7f6fb)
This was referenced Nov 9, 2022
eirsep
pushed a commit
that referenced
this pull request
Nov 9, 2022
* dns and cloudtrail mappings Signed-off-by: Grant Haywood <grant@phaseshift.studio> * add s3 mappings Signed-off-by: Grant Haywood <grant@phaseshift.studio> Signed-off-by: Grant Haywood <grant@phaseshift.studio> (cherry picked from commit ee7f6fb) Co-authored-by: phaseshiftg <115187865+phaseshiftg@users.noreply.github.com>
eirsep
pushed a commit
that referenced
this pull request
Nov 9, 2022
* dns and cloudtrail mappings Signed-off-by: Grant Haywood <grant@phaseshift.studio> * add s3 mappings Signed-off-by: Grant Haywood <grant@phaseshift.studio> Signed-off-by: Grant Haywood <grant@phaseshift.studio> (cherry picked from commit ee7f6fb) Co-authored-by: phaseshiftg <115187865+phaseshiftg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds DNS mappings, adds a test case to MappingsIT that reads the json file from resources and submits it via the API
Issues Resolved
Mapping curation, for DNS
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.