Change the version parsing command's regex to handle double digits minor versions #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le digits of minor versions Signed-off-by: Ryan Liang <jiallian@amazon.com>
RyanL1997
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied and
scrawfor99
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1537 +/- ##
=======================================
Coverage 66.06% 66.06%
=======================================
Files 93 93
Lines 2328 2328
Branches 310 310
=======================================
Hits 1538 1538
Misses 722 722
Partials 68 68 |
cwperks
approved these changes
Aug 3, 2023
|
Can another maintainer review this PR? |
peternied
approved these changes
Aug 3, 2023
samuelcostae
pushed a commit
to samuelcostae/security-dashboards-plugin
that referenced
this pull request
Aug 10, 2023
…le digits of minor versions (opensearch-project#1537) Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Sam <samuel.costa@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the version parsing command's regex to handle double digits minor versions
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Enhancement
Issues Resolved
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.