Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated issue templates from .github. #1740

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Apr 4, 2022

Signed-off-by: dblock dblock@dblock.org

Description

Coming from opensearch-project/.github#64, updated issue templates for bugs and features.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from a team April 4, 2022 19:51
peternied
peternied previously approved these changes Apr 4, 2022
Signed-off-by: dblock <dblock@dblock.org>
peternied
peternied previously approved these changes Apr 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #1740 (ad4d5c7) into main (c7e58e5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1740   +/-   ##
=========================================
  Coverage     62.89%   62.89%           
- Complexity     3265     3266    +1     
=========================================
  Files           253      253           
  Lines         18102    18102           
  Branches       3247     3247           
=========================================
  Hits          11385    11385           
  Misses         5063     5063           
  Partials       1654     1654           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e58e5...ad4d5c7. Read the comment docs.

davidlago
davidlago previously approved these changes Apr 5, 2022
@davidlago
Copy link

davidlago commented Apr 5, 2022

Failed code hygiene check

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied dismissed stale reviews from davidlago and themself via 2ad5b14 April 5, 2022 17:17
@peternied
Copy link
Member

@dblock FYI - I've fixed the line endings issue and pushed that commit to your fork, we will merge this change as soon as CI passes. Thanks!

@davidlago davidlago merged commit 2972bd1 into opensearch-project:main Apr 5, 2022
@dblock
Copy link
Member Author

dblock commented Apr 5, 2022

I feel like I should fix the line endings in .github ...

@peternied
Copy link
Member

peternied commented Apr 6, 2022

I feel like I should fix the line endings in .github ...

@dblock I resolved this in 2ad5b14 which I pushed to your branch before merging.

Edit: Oh you meant in the .github project not the .github folder, that is a good idea. I've approved that PR

@dblock dblock deleted the meta-templates branch April 12, 2022 23:03
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
* Updated issue templates from .github.

Signed-off-by: dblock <dblock@dblock.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants