Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Andrey Pleskach (Willyborankin) to Maintainers #2843

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

scrawfor99
Copy link
Collaborator

Please join me in welcoming Andrey Pleskach @willyborankin to the Security repository maintainers!

At the time of his nomination Andrey currently had the 20th most contributions to the Security repository, and had added a total of 3,834 lines of code while removing 1,958. Notable features Andrey has driven include safe password restrictions, rest admin permissions, and fixes for the multitenancy update. Further, Andrey is a heavily involved member of the community coming to every weekly triaging meeting for quite some time (despite being based abroad). Altogether, the Security repository maintainers unanimously voted that Andrey be invited to join for his expertise and commitment. We are all sure he will be a great boost to the repositories’ management.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@scrawfor99 scrawfor99 added backport 1.x backport to 1.x branch backport 1.3 backport to 1.3 branch backport 2.x backport to 2.x branch labels Jun 8, 2023
MAINTAINERS.md Outdated Show resolved Hide resolved
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
reta
reta previously approved these changes Jun 8, 2023
MAINTAINERS.md Show resolved Hide resolved
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all of the great contributions @willyborankin! You are raising the bar for OpenSearch security.

This is well-deserved and I look forward to continued collaboration!

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #2843 (d18b480) into main (ceb5ad2) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2843      +/-   ##
============================================
- Coverage     61.60%   61.59%   -0.01%     
+ Complexity     3414     3413       -1     
============================================
  Files           266      266              
  Lines         18917    18917              
  Branches       3303     3303              
============================================
- Hits          11653    11652       -1     
  Misses         5669     5669              
- Partials       1595     1596       +1     

see 1 file with indirect coverage changes

@willyborankin
Copy link
Collaborator

willyborankin commented Jun 8, 2023

Thank you!!!!

@davidlago
Copy link

Raising my virtual glass to you, @willyborankin! Thanks for all your good work and welcome!

@DarshitChanpura
Copy link
Member

Welcome aboard @willyborankin !! Thank you for all great contributions thus far and looking forward to ones in future !!

@peternied peternied added backport 1.x backport to 1.x branch backport 1.3 backport to 1.3 branch backport 2.x backport to 2.x branch and removed backport 1.x backport to 1.x branch backport 1.3 backport to 1.3 branch backport 2.x backport to 2.x branch labels Jun 8, 2023
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well earned, thanks @willyborankin!

@scrawfor99 scrawfor99 merged commit 0dbd84c into opensearch-project:main Jun 13, 2023
27 of 28 checks passed
@scrawfor99 scrawfor99 deleted the addWilly branch June 13, 2023 15:06
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2843-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0dbd84cb2b2ff301f67ad26b743254af8c7d4dba
# Push it to GitHub
git push --set-upstream origin backport/backport-2843-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2843-to-1.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2843-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0dbd84cb2b2ff301f67ad26b743254af8c7d4dba
# Push it to GitHub
git push --set-upstream origin backport/backport-2843-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-2843-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2843-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0dbd84cb2b2ff301f67ad26b743254af8c7d4dba
# Push it to GitHub
git push --set-upstream origin backport/backport-2843-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2843-to-2.x.

peternied pushed a commit to peternied/security that referenced this pull request Jun 13, 2023
…ensearch-project#2843)

* Add Andrey to Maintainers

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: Peter Nied <petern@amazon.com>
peternied pushed a commit to peternied/security that referenced this pull request Jun 13, 2023
…ensearch-project#2843)

* Add Andrey to Maintainers

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: Peter Nied <petern@amazon.com>
peternied pushed a commit to peternied/security that referenced this pull request Jun 13, 2023
…ensearch-project#2843)

* Add Andrey to Maintainers

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied
Copy link
Member

Added manual backport PRs

RyanL1997 pushed a commit to RyanL1997/security that referenced this pull request Jun 13, 2023
…t#2843)

* Add Andrey to Maintainers

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Update MAINTAINERS.md

Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>

* Update codeowners

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
peternied added a commit that referenced this pull request Jun 13, 2023
) (#2851)

* Add Andrey to Maintainers

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
peternied added a commit that referenced this pull request Jun 13, 2023
) (#2852)

* Add Andrey to Maintainers

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
peternied added a commit that referenced this pull request Jun 13, 2023
) (#2850)

* Add Andrey to Maintainers

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
samuelcostae pushed a commit to samuelcostae/security that referenced this pull request Jun 19, 2023
…t#2843)

* Add Andrey to Maintainers

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Update MAINTAINERS.md

Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>

* Update codeowners

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
samuelcostae pushed a commit to samuelcostae/security that referenced this pull request Jun 19, 2023
…t#2843)

* Add Andrey to Maintainers

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Update MAINTAINERS.md

Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>

* Update codeowners

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: Sam <samuel.costa@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport to 1.x branch backport 1.3 backport to 1.3 branch backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants