Validate content type of responses #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
force-pushed
the
content-type-validate
branch
3 times, most recently
from
1f424f7
to
f699383
Compare
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
force-pushed
the
content-type-validate
branch
from
f699383
to
42c05dc
Compare
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
RyanL1997,
scrawfor99,
reta and
willyborankin
as code owners
peternied
commented
Nov 17, 2023
src/integrationTest/java/org/opensearch/test/framework/cluster/TestRestClient.java
Show resolved
Hide resolved
willyborankin
approved these changes
Nov 17, 2023
cwperks
approved these changes
Nov 17, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3719-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c30c084b911d00f94683bcccc0d1acd32461a001
# Push it to GitHub
git push --set-upstream origin backport/backport-3719-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
peternied
added a commit
to peternied/security
that referenced
this pull request
Nov 21, 2023
…#3719) Makes sure that for response with a body they are returning the expected content type Signed-off-by: Peter Nied <petern@amazon.com>
peternied
added a commit
to peternied/security
that referenced
this pull request
Nov 21, 2023
…#3719) Makes sure that for response with a body they are returning the expected content type Signed-off-by: Peter Nied <petern@amazon.com>
3 tasks
peternied
added a commit
to peternied/security
that referenced
this pull request
Nov 21, 2023
…#3719) Makes sure that for response with a body they are returning the expected content type Signed-off-by: Peter Nied <petern@amazon.com>
peternied
added a commit
to peternied/security
that referenced
this pull request
Nov 21, 2023
…#3719) Makes sure that for response with a body they are returning the expected content type Signed-off-by: Peter Nied <petern@amazon.com>
peternied
added a commit
that referenced
this pull request
Nov 22, 2023
prabhask5
pushed a commit
to prabhask5/opensearch-security
that referenced
this pull request
Jan 11, 2024
Makes sure that for response with a body they are returning the expected content type Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Prabhas Kurapati <prabhask@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes sure that for response with a body they are returning the expected content type
Issues Resolved
Check List
New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.