[DRAFT Backport 2.11] Minor comments follow up for integration tests #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <cwperx@amazon.com>
- Remove an unused JVM setting for integration tests - Fixed an issue where you couldn't run non-resource tests unless you had CI_ENVIRONMENT set to normal on your machine (Already fixed in main) - Fixed an issue where code coverage was always run after tests completed (Already fixed in main) - Related opensearch-project#3388 Signed-off-by: Peter Nied <petern@amazon.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.11 #3752 +/- ##
============================================
- Coverage 64.86% 64.68% -0.19%
+ Complexity 3613 3527 -86
============================================
Files 273 273
Lines 20024 20054 +30
Branches 3346 3348 +2
============================================
- Hits 12989 12972 -17
- Misses 5389 5410 +21
- Partials 1646 1672 +26 |
cwperks
commented
Nov 20, 2023
| @@ -398,8 +398,6 @@ tasks.withType(JavaCompile) { | |||
| } | |||
|
|
|||
| tasks.test.finalizedBy(jacocoTestReport) // report is always generated after tests run | |||
| tasks.jacocoTestReport.dependsOn(test) // tests are required to run before generating the report | |||
There was a problem hiding this comment.
This long could be causing the slowdown because all tasks are finalized by jacocoTestReport and jacocoTestReport depends on test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been issues with long-running CI on the 2.11 branch. I am opening a Draft PR to backport #3427 to determine if the reason for longer running CI is because this PR was backported to 2.x, but is not in 2.11.