Re-enable disabled PIT integration tests #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
scrawfor99,
reta and
willyborankin
as code owners
willyborankin
previously approved these changes
Dec 19, 2023
peternied
reviewed
Jan 2, 2024
src/integrationTest/java/org/opensearch/security/PointInTimeOperationTest.java
Outdated
Show resolved
Hide resolved
Merged
8 tasks
Signed-off-by: Craig Perkins <cwperx@amazon.com>
peternied
approved these changes
Jan 3, 2024
willyborankin
approved these changes
Jan 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
### Description Re-enables 2 PIT integration tests that were previously disabled. This adds a @before method to clean up all PITs created from previous test cases to ensure each test case runs pristinely. * Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Test fix ### Issues Resolved - #3424 Is this a backport? If so, please add backport PR # and/or commits # ### Testing [Please provide details of testing done: unit testing, integration testing and manual testing] ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit f216743) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 tasks
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
### Description Re-enables 2 PIT integration tests that were previously disabled. This adds a @before method to clean up all PITs created from previous test cases to ensure each test case runs pristinely. * Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Test fix ### Issues Resolved - opensearch-project#3424 Is this a backport? If so, please add backport PR # and/or commits # ### Testing [Please provide details of testing done: unit testing, integration testing and manual testing] ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-enables 2 PIT integration tests that were previously disabled. This adds a @before method to clean up all PITs created from previous test cases to ensure each test case runs pristinely.
Test fix
Issues Resolved
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.