Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix: remove unnecessary trailing slashes in APIs. #3978

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport dadd03f from #3976.

### Description

Coming from
opensearch-project/opensearch-api-specification#179
which flags a couple of false positives because of mismatched trailing
slash.

### Check List
- [x] New functionality includes testing
- [x] New functionality has been documented
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: dblock <dblock@amazon.com>
(cherry picked from commit dadd03f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a0c3dba) 65.39% compared to head (9c0ca21) 65.48%.
Report is 4 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #3978      +/-   ##
==========================================
+ Coverage   65.39%   65.48%   +0.09%     
==========================================
  Files         297      297              
  Lines       21051    21051              
  Branches     3447     3443       -4     
==========================================
+ Hits        13767    13786      +19     
+ Misses       5574     5557      -17     
+ Partials     1710     1708       -2     
Files Coverage Δ
.../security/dlic/rest/api/ActionGroupsApiAction.java 97.61% <ø> (ø)
...nsearch/security/dlic/rest/api/AuditApiAction.java 93.84% <ø> (+3.07%) ⬆️
...security/dlic/rest/api/InternalUsersApiAction.java 81.41% <ø> (ø)
...earch/security/dlic/rest/api/NodesDnApiAction.java 89.74% <ø> (ø)
...nsearch/security/dlic/rest/api/RolesApiAction.java 95.83% <ø> (ø)
.../security/dlic/rest/api/RolesMappingApiAction.java 97.05% <ø> (ø)
...urity/dlic/rest/api/SecuritySSLCertsApiAction.java 82.35% <100.00%> (ø)
...earch/security/dlic/rest/api/TenantsApiAction.java 41.17% <ø> (ø)
...ch/security/securityconf/DynamicConfigModelV7.java 65.51% <100.00%> (-0.79%) ⬇️
...pensearch/security/setting/DeprecatedSettings.java 85.71% <100.00%> (+5.71%) ⬆️
... and 4 more

... and 3 files with indirect coverage changes

@cwperks cwperks merged commit b8ab43b into 2.x Jan 23, 2024
88 checks passed
@cwperks cwperks deleted the backport/backport-3976-to-2.x branch January 23, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants