Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin role for Query insights plugin #4006

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Jan 31, 2024

Description

Adding the default role for query insights plugin

Related issues and PRs

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (157d137) 65.56% compared to head (de81a2e) 65.63%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4006      +/-   ##
==========================================
+ Coverage   65.56%   65.63%   +0.06%     
==========================================
  Files         298      298              
  Lines       21246    21247       +1     
  Branches     3457     3457              
==========================================
+ Hits        13930    13945      +15     
+ Misses       5595     5582      -13     
+ Partials     1721     1720       -1     

see 5 files with indirect coverage changes

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rename the action names to follow the conventions used by the other OpenSearch plugins

Oh, this isn't a plugin... even yet, lets review this with product to see if we can get these aligned. @ansjcy Can you reach out to the product team for this?

@ansjcy
Copy link
Member Author

ansjcy commented Feb 1, 2024

Hi @peternied, query insights would be a new plugin to be added in 2.12, and this is for the new endpoint to be added as part of https://github.com/opensearch-project/OpenSearch/pull/11904/files#diff-8f667a33ab21bed061e1f79e106a9686526ad54be9c0be568a532459c6e89ce2R27.

I have chatted with the TPM to confirm on the naming as well.

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks much more consistent. Note; you'll need to update the transport actions names in OpenSearch core before this will work end to end.

@peternied peternied added the backport 2.x backport to 2.x branch label Feb 1, 2024
@peternied peternied changed the title adding the default role for query insights plugin Admin role for Query insights plugin Feb 1, 2024
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @ansjcy Would you please create a PR on the dashboards-plugin if we are planning to make this action 'cluster:admin/opensearch/insights/top_queries/*' permission-able via UI.

@DarshitChanpura DarshitChanpura merged commit 6b9ded2 into opensearch-project:main Feb 5, 2024
83 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 5, 2024
Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 6b9ded2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks pushed a commit that referenced this pull request Feb 5, 2024
Backport 6b9ded2 from #4006.

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dlin2028 pushed a commit to dlin2028/security that referenced this pull request May 1, 2024

Signed-off-by: Chenyang Ji <cyji@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants