[Backport 2.x] Fix unconsumed parameter exception when authenticating with jwtUrlParameter

[opensearch-trigger-bot]

Backport ccea744 from #3975.

[DarshitChanpura]

/home/runner/work/security/security/src/integrationTest/java/org/opensearch/security/http/JwtAuthenticationWithUrlParamTests.java:18: error: package org.apache.hc.core5.http does not exist
import org.apache.hc.core5.http.Header;

🤧 .. needs a manual commit to revert to http4

[peternied]

@DarshitChanpura Thanks for looking, I'll get this mergeable

[cwperks]

Capturing the error seen on CI. Its not related to the code change, but I have never seen it before so wanted to capture it in a comment.

Suite: Test class org.opensearch.security.EncryptionInTransitMigrationTests
  1> [2024-02-23T14:36:00,313][WARN ][org.opensearch.node.Node] version [2.13.0-SNAPSHOT] is a pre-release version of OpenSearch and is not suitable for production
  2> java.lang.IllegalStateException: availableProcessors is already set to [4], rejecting [4]
        at __randomizedtesting.SeedInfo.seed([ED0C28D4A6E072ED:556970ADC10FAE25]:0)
        at io.netty.util.NettyRuntime$AvailableProcessorsHolder.setAvailableProcessors(NettyRuntime.java:51)
        at io.netty.util.NettyRuntime.setAvailableProcessors(NettyRuntime.java:87)
        at org.opensearch.transport.netty4.Netty4Utils.setAvailableProcessors(Netty4Utils.java:75)
        at org.opensearch.transport.netty4.Netty4Transport.<init>(Netty4Transport.java:139)
        at org.opensearch.transport.Netty4Plugin.lambda$getTransports$0(Netty4Plugin.java:112)
        at org.opensearch.node.Node.<init>(Node.java:970)
        at org.opensearch.node.PluginAwareNode.<init>(PluginAwareNode.java:44)
        at org.opensearch.security.test.helper.cluster.ClusterHelper.startCluster(ClusterHelper.java:215)
        at org.opensearch.security.test.helper.cluster.ClusterHelper.startCluster(ClusterHelper.java:124)
        at org.opensearch.security.test.SingleClusterTest.setupSslOnlyModeWithClusterManagerNodeWithoutSSL(SingleClusterTest.java:136)
        at org.opensearch.security.EncryptionInTransitMigrationTests.testSslOnlyModeDualModeWithNonSSLClusterManagerNode(EncryptionInTransitMigrationTests.java:108)

Tests with failures:
 - com.amazon.dlic.auth.http.jwt.keybyoidc.KeySetRetrieverTest.classMethod
 - com.amazon.dlic.auth.http.saml.HTTPSamlAuthenticatorTest.noSignatureTest
 - org.opensearch.security.EncryptionInTransitMigrationTests.testSslOnlyModeDualModeWithNonSSLClusterManagerNode

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.75%. Comparing base (865ae80) to head (6fa6edc).
Report is 2 commits behind head on 2.x.

Additional details and impacted files

@@            Coverage Diff             @@
##              2.x    #4065      +/-   ##
==========================================
+ Coverage   65.70%   65.75%   +0.05%     
==========================================
  Files         297      297              
  Lines       21094    21115      +21     
  Branches     3453     3455       +2     
==========================================
+ Hits        13860    13885      +25     
+ Misses       5508     5502       -6     
- Partials     1726     1728       +2     

Files	Coverage Δ
...rg/opensearch/security/filter/SecurityRequest.java	100.00% <ø> (ø)
...opensearch/security/filter/SecurityRestFilter.java	70.37% <100.00%> (+1.13%)	⬆️
...rch/security/http/SecurityHttpServerTransport.java	100.00% <100.00%> (ø)
...sl/http/netty/Netty4HttpRequestHeaderVerifier.java	85.71% <100.00%> (+0.34%)	⬆️
...a/org/opensearch/security/filter/NettyRequest.java	90.62% <90.00%> (+3.66%)	⬆️
.../opensearch/security/filter/OpenSearchRequest.java	73.33% <66.66%> (-3.59%)	⬇️

... and 4 files with indirect coverage changes