Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #57

Closed
Tracked by #125
dblock opened this issue Feb 14, 2023 · 5 comments · Fixed by #60 or #68
Closed
Tracked by #125

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions #57

dblock opened this issue Feb 14, 2023 · 5 comments · Fixed by #60 or #68
Assignees

Comments

@dblock
Copy link
Member

dblock commented Feb 14, 2023

Follow opensearch-project/.github#125 to baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions.

Close this issue when:

  1. MAINTAINERS.md has the correct list of project maintainers.
  2. CODEOWNERS exists and has the correct list of aliases.
  3. Repo permissions only contain individual aliases as collaborators with maintain rights, admin, and triage teams.
  4. All other teams are removed from repo permissions.

If this repo's permissions was already baselined, please confirm the above when closing this issue.

@dblock
Copy link
Member Author

dblock commented Mar 9, 2023

You have the sql group with 18 members that has maintain access to this repo. Only folks listed in MAINTAINERS/CODEOWNERS need to have maintain access, and groups don't support external collaborators. Please work with an admin to remove the group and add individuals.

@dblock dblock reopened this Mar 9, 2023
@dblock
Copy link
Member Author

dblock commented Apr 4, 2023

Screenshot 2023-04-04 at 3 18 19 PM

@anirudha anirudha self-assigned this Apr 24, 2023
@bbarani
Copy link
Member

bbarani commented Apr 24, 2023

Added the users listed in MAINTAINERS.md file as maintainers of this repo. @anirudha @joshuali925 Please add CODEOWNERS file under .github directory with the maintainers list. CC: @dblock @CEHENKLE

Also, I am not able to add MaxKsyunz and Yury-Fridlyand as they are not part of the organization yet. Please update the maintainers list as needed.

@derek-ho
Copy link
Collaborator

This is done, pending adding yury and max to github, which I have opened a ticket for

@dblock
Copy link
Member Author

dblock commented Apr 27, 2023

Verified, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants