Fix windows signing and remove macos due to limitations (#56)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
opensearch-project · Jul 3, 2023 · 2d10f84 · 2d10f84
1 parent 36f736d
commit 2d10f84
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/jenkins/release.jenkinsFile b/jenkins/release.jenkinsFile
@@ -10,26 +10,16 @@ standardReleasePipelineWithGenericTrigger(
     publishRelease: true) {
                         publishToArtifactsProdBucket(
                             assumedRoleName: 'sql-odbc-upload-role',
-                            source: 'windows32-installer/OpenSearch-SQL-ODBC-Driver-32-bit-1.5.0.0-Windows.msi',
-                            destination: 'opensearch-clients/odbc/opensearch-sql-odbc-driver-32-bit-1.5.0.0-Windows.msi',
+                            source: "windows32-installer/OpenSearch-SQL-ODBC-Driver-32-bit-${tag}-Windows.msi",
+                            destination: "opensearch-clients/odbc/opensearch-sql-odbc-driver-32-bit-${tag}-Windows.msi",
                             signingPlatform: 'windows',
-                            sigType: 'null',
                             sigOverwrite: true
                         )
                         publishToArtifactsProdBucket(
                             assumedRoleName: 'sql-odbc-upload-role',
-                            source: 'windows64-installer/OpenSearch-SQL-ODBC-Driver-64-bit-1.5.0.0-Windows.msi',
-                            destination: 'opensearch-clients/odbc/opensearch-sql-odbc-driver-64-bit-1.5.0.0-Windows.msi',
+                            source: "windows64-installer/OpenSearch-SQL-ODBC-Driver-64-bit-${tag}-Windows.msi",
+                            destination: "opensearch-clients/odbc/opensearch-sql-odbc-driver-64-bit-${tag}-Windows.msi",
                             signingPlatform: 'windows',
-                            sigType: 'null',
-                            sigOverwrite: true
-                        )
-                        publishToArtifactsProdBucket(
-                            assumedRoleName: 'sql-odbc-upload-role',
-                            source: 'mac64-installer/OpenSearch-SQL-ODBC-Driver-64-bit-1.5.0.0-Darwin.pkg',
-                            destination: 'opensearch-clients/odbc/opensearch-sql-odbc-driver-64-bit-1.5.0.0-Darwin.pkg',
-                            signingPlatform: 'mac',
-                            sigType: 'null',
                             sigOverwrite: true
                         )
     }
diff --git a/release-notes/sql-odbc.OpenSearch.release-notes-1.5.0.0.md b/release-notes/sql-odbc.OpenSearch.release-notes-1.5.0.0.md
@@ -14,6 +14,7 @@
 * ODBC SSL Compliance Fix ([#653](https://github.com/opensearch-project/sql/pull/653))
 * Reverted UseSSL flag to false and removed invalid test case ([#671](https://github.com/opensearch-project/sql/pull/671))
 * Fix jenkins lib version to accommodate mac signing ([#54](https://github.com/opensearch-project/sql-odbc/pull/54))
+* Fix windows signing and remove macos due to limitations ([#56](https://github.com/opensearch-project/sql-odbc/pull/56))
 
 ### Documentation